Prompt file imported from nadir511/PlcTelegramSimulator (
.github/prompts/review-changes.prompt.md). Copyright stays with the author.
Goal
Perform a high-signal review of the current change set (or the scope/PR in the argument).
Steps
- Read the diff, the plan (if any), and relevant ADRs; understand the intent first.
- Trace the critical paths:
- Backend — telegram framing/encoding, transport lifecycle,
CancellationTokenon I/O, API contract, error handling, layer boundaries (Web/Infrastructure→Application→Domain). - Frontend — data flow, live-stream subscribe/cleanup, typed API usage, loading/error states.
- Backend — telegram framing/encoding, transport lifecycle,
- Check security: no secrets committed or logged, external input validated, no unsafe deserialization.
- Confirm tests exist for the behavior changed and actually exercise it.
- Report findings by severity (blocking / warning / info) with file:line evidence and your
confidence. Skip nits already handled by
dotnet format/ ESLint. Missing tests for a behavior change = blocking.
