Prompt file imported from talkincode/toughradius (.github/prompts/push.prompt.md). Copyright stays with the author.

Test, Fix, Commit and Push Workflow

Name: push
Author: talkincode

Execute a complete development workflow that ensures code quality before pushing changes to the remote repository.

Workflow Steps

1. Run All Tests

Execute comprehensive testing across the entire project:

Backend Tests:

Run all Go unit tests: go test ./...
Run RADIUS protocol tests: go test ./internal/radiusd/...
Run benchmark tests if applicable: go test -bench=. ./internal/radiusd/
Check for race conditions: go test -race ./...

Frontend Tests:

Navigate to web/ directory
Run frontend tests: npm test or npm run test
Run build validation: npm run build to ensure production build succeeds

Integration Tests:

Verify database migrations work: Check app.MigrateDB() functionality
Test RADIUS authentication flow end-to-end if changes affect core services
Validate API endpoints if admin API routes were modified

2. Fix Issues

If any tests fail:

Analyze the failure output carefully
Trace the root cause through the codebase
Apply fixes following project conventions:
- Maintain consistent error handling patterns
- Follow existing logging standards (zap with namespace)
- Preserve architectural patterns (errgroup for services, app.GDB() for database access)
- Update vendor-specific code according to specifications
Re-run ALL tests after each fix
Iterate until all tests pass

Do not proceed to commit until all tests pass successfully.

3. Commit Changes

Once all tests pass, commit the changes with proper organization:

Commit Strategy:

Small changes (1-5 files): Single commit
Large changes: Categorize into logical batches:
- Group by feature/component (e.g., "auth service", "admin API", "frontend UI")
- Separate backend and frontend changes
- Isolate refactoring from new features
- Keep test updates with their corresponding code changes

Commit Message Format:

Follow conventional commits specification:

<type>(<scope>): <subject>

<body>

<footer>

Types:

feat: New feature
fix: Bug fix
refactor: Code restructuring without behavior change
perf: Performance improvement
test: Adding or updating tests
docs: Documentation changes
chore: Build process, dependencies, configs
style: Code formatting (not UI styles)

Scope examples:

radiusd: RADIUS service core
adminapi: Admin API routes
webserver: Web server/middleware
domain: Data models
vendors: Vendor-specific implementations
frontend: React Admin UI
config: Configuration handling

Examples:

feat(radiusd): add support for Huawei bandwidth VSA attributes

Implement parsing and handling of Huawei-specific VSA attributes
for dynamic bandwidth allocation. Supports input/output average
rate configuration per RFC and Huawei specifications.

- Add ParseHuaweiInputAverageRate function
- Update auth_accept_config.go with bandwidth conversion
- Add unit tests for VSA attribute parsing

Closes #123

fix(adminapi): resolve user session limit validation error

Correct the max session check logic that was incorrectly rejecting
valid concurrent sessions. The previous implementation didn't account
for NAS IP filtering.

- Update session count query to include NAS IP
- Add integration test for multi-NAS scenarios
- Update error message for clarity

refactor(domain): migrate user model to use GORM hooks

Replace manual timestamp updates with GORM's built-in hooks for
better consistency and reduced boilerplate.

- Add BeforeCreate/BeforeUpdate hooks
- Remove manual timestamp setting in services
- Update related tests

Commit Command Pattern:

git add <files-for-this-batch>
git commit -m "<type>(<scope>): <subject>" -m "<body>" -m "<footer>"

4. Push to Remote

After all commits are created:

# Review all commits before pushing
git log --oneline -n <number-of-commits>

# Push to remote
git push origin <branch-name>

Pre-push Checklist:

✅ All tests passing
✅ Commits follow conventional format
✅ Related changes grouped logically
✅ Commit messages are clear and descriptive
✅ No sensitive data in commits
✅ Branch is up to date with remote (pull/rebase if needed)

Error Handling

If push fails:

Conflict: Pull latest changes, resolve conflicts, re-test, then push
Rejected: Check if branch protection requires PR or review
Authentication: Verify Git credentials and remote URL

Success Criteria

The workflow is complete when:

All backend and frontend tests pass
All changes are committed with proper messages
Commits are successfully pushed to remote repository
No errors or warnings in the process

Notes

Never skip tests even for "small" changes
Always verify production build succeeds for frontend changes
Keep commits atomic and focused
Write commit messages for future maintainers, not just yourself
Follow ToughRADIUS coding standards from .github/copilot-instructions.md

# Test, Fix, Commit and Push Workflow Execute a complete development workflow that ensures code quality before pushing changes to the remote repository. ## Workflow Steps ### 1. Run All Tests Execute comprehensive testing across the entire project: **Backend Tests:** - Run all Go unit tests: `go test ./...` - Run RADIUS protocol tests: `go test ./internal/radiusd/...` - Run benchmark tests if applicable: `go test -bench=. ./internal/radiusd/` - Check for race conditions: `go test -race ./...` **Frontend Tests:** - Navigate to `web/` directory - Run frontend tests: `npm test` or `npm run test` - Run build validation: `npm run build` to ensure production build succeeds **Integration Tests:** - Verify database migrations work: Check `app.MigrateDB()` functionality - Test RADIUS authentication flow end-to-end if changes affect core services - Validate API endpoints if admin API routes were modified ### 2. Fix Issues If any tests fail: - Analyze the failure output carefully - Trace the root cause through the codebase - Apply fixes following project conventions: - Maintain consistent error handling patterns - Follow existing logging standards (zap with namespace) - Preserve architectural patterns (errgroup for services, app.GDB() for database access) - Update vendor-specific code according to specifications - Re-run ALL tests after each fix - Iterate until all tests pass **Do not proceed to commit until all tests pass successfully.** ### 3. Commit Changes Once all tests pass, commit the changes with proper organization: **Commit Strategy:** - **Small changes (1-5 files):** Single commit - **Large changes:** Categorize into logical batches: - Group by feature/component (e.g., "auth service", "admin API", "frontend UI") - Separate backend and frontend changes - Isolate refactoring from new features - Keep test updates with their corresponding code changes **Commit Message Format:** Follow conventional commits specification: ``` <type>(<scope>): <subject> <body> <footer> ``` **Types:** - `feat`: New feature - `fix`: Bug fix - `refactor`: Code restructuring without behavior change - `perf`: Performance improvement - `test`: Adding or updating tests - `docs`: Documentation changes - `chore`: Build process, dependencies, configs - `style`: Code formatting (not UI styles) **Scope examples:** - `radiusd`: RADIUS service core - `adminapi`: Admin API routes - `webserver`: Web server/middleware - `domain`: Data models - `vendors`: Vendor-specific implementations - `frontend`: React Admin UI - `config`: Configuration handling **Examples:** ``` feat(radiusd): add support for Huawei bandwidth VSA attributes Implement parsing and handling of Huawei-specific VSA attributes for dynamic bandwidth allocation. Supports input/output average rate configuration per RFC and Huawei specifications. - Add ParseHuaweiInputAverageRate function - Update auth_accept_config.go with bandwidth conversion - Add unit tests for VSA attribute parsing Closes #123 ``` ``` fix(adminapi): resolve user session limit validation error Correct the max session check logic that was incorrectly rejecting valid concurrent sessions. The previous implementation didn't account for NAS IP filtering. - Update session count query to include NAS IP - Add integration test for multi-NAS scenarios - Update error message for clarity ``` ``` refactor(domain): migrate user model to use GORM hooks Replace manual timestamp updates with GORM's built-in hooks for better consistency and reduced boilerplate. - Add BeforeCreate/BeforeUpdate hooks - Remove manual timestamp setting in services - Update related tests ``` **Commit Command Pattern:** ```bash git add <files-for-this-batch> git commit -m "<type>(<scope>): <subject>" -m "<body>" -m "<footer>" ``` ### 4. Push to Remote After all commits are created: ```bash # Review all commits before pushing git log --oneline -n <number-of-commits> # Push to remote git push origin <branch-name> ``` **Pre-push Checklist:** - ✅ All tests passing - ✅ Commits follow conventional format - ✅ Related changes grouped logically - ✅ Commit messages are clear and descriptive - ✅ No sensitive data in commits - ✅ Branch is up to date with remote (pull/rebase if needed) ## Error Handling If push fails: - **Conflict:** Pull latest changes, resolve conflicts, re-test, then push - **Rejected:** Check if branch protection requires PR or review - **Authentication:** Verify Git credentials and remote URL ## Success Criteria The workflow is complete when: 1. All backend and frontend tests pass 2. All changes are committed with proper messages 3. Commits are successfully pushed to remote repository 4. No errors or warnings in the process ## Notes - Never skip tests even for "small" changes - Always verify production build succeeds for frontend changes - Keep commits atomic and focused - Write commit messages for future maintainers, not just yourself - Follow ToughRADIUS coding standards from `.github/copilot-instructions.md`

{ "prompt": "# Test, Fix, Commit and Push Workflow\n\nExecute a complete development workflow that ensures code quality before pushing changes to the remote repository.\n\n## Workflow Steps\n\n### 1. Run All Tests\n\nExecute comprehensive testing across the entire project:\n\n**Backend Tests:**\n\n- Run all Go unit tests: `go test ./...`\n- Run RADIUS protocol tests: `go test ./internal/radiusd/...`\n- Run benchmark tests if applicable: `go test -bench=. ./internal/radiusd/`\n- Check for race conditions: `go test -race ./...`\n\n**Frontend Tests:**\n\n- Navigate to `web/` directory\n- Run frontend tests: `npm test` or `npm run test`\n- Run build validation: `npm run build` to ensure production build succeeds\n\n**Integration Tests:**\n\n- Verify database migrations work: Check `app.MigrateDB()` functionality\n- Test RADIUS authentication flow end-to-end if changes affect core services\n- Validate API endpoints if admin API routes were modified\n\n### 2. Fix Issues\n\nIf any tests fail:\n\n- Analyze the failure output carefully\n- Trace the root cause through the codebase\n- Apply fixes following project conventions:\n - Maintain consistent error handling patterns\n - Follow existing logging standards (zap with namespace)\n - Preserve architectural patterns (errgroup for services, app.GDB() for database access)\n - Update vendor-specific code according to specifications\n- Re-run ALL tests after each fix\n- Iterate until all tests pass\n\n**Do not proceed to commit until all tests pass successfully.**\n\n### 3. Commit Changes\n\nOnce all tests pass, commit the changes with proper organization:\n\n**Commit Strategy:**\n\n- **Small changes (1-5 files):** Single commit\n- **Large changes:** Categorize into logical batches:\n - Group by feature/component (e.g., \"auth service\", \"admin API\", \"frontend UI\")\n - Separate backend and frontend changes\n - Isolate refactoring from new features\n - Keep test updates with their corresponding code changes\n\n**Commit Message Format:**\n\nFollow conventional commits specification:\n\n```\n<type>(<scope>): <subject>\n\n<body>\n\n<footer>\n```\n\n**Types:**\n\n- `feat`: New feature\n- `fix`: Bug fix\n- `refactor`: Code restructuring without behavior change\n- `perf`: Performance improvement\n- `test`: Adding or updating tests\n- `docs`: Documentation changes\n- `chore`: Build process, dependencies, configs\n- `style`: Code formatting (not UI styles)\n\n**Scope examples:**\n\n- `radiusd`: RADIUS service core\n- `adminapi`: Admin API routes\n- `webserver`: Web server/middleware\n- `domain`: Data models\n- `vendors`: Vendor-specific implementations\n- `frontend`: React Admin UI\n- `config`: Configuration handling\n\n**Examples:**\n\n```\nfeat(radiusd): add support for Huawei bandwidth VSA attributes\n\nImplement parsing and handling of Huawei-specific VSA attributes\nfor dynamic bandwidth allocation. Supports input/output average\nrate configuration per RFC and Huawei specifications.\n\n- Add ParseHuaweiInputAverageRate function\n- Update auth_accept_config.go with bandwidth conversion\n- Add unit tests for VSA attribute parsing\n\nCloses #123\n```\n\n```\nfix(adminapi): resolve user session limit validation error\n\nCorrect the max session check logic that was incorrectly rejecting\nvalid concurrent sessions. The previous implementation didn't account\nfor NAS IP filtering.\n\n- Update session count query to include NAS IP\n- Add integration test for multi-NAS scenarios\n- Update error message for clarity\n```\n\n```\nrefactor(domain): migrate user model to use GORM hooks\n\nReplace manual timestamp updates with GORM's built-in hooks for\nbetter consistency and reduced boilerplate.\n\n- Add BeforeCreate/BeforeUpdate hooks\n- Remove manual timestamp setting in services\n- Update related tests\n```\n\n**Commit Command Pattern:**\n\n```bash\ngit add <files-for-this-batch>\ngit commit -m \"<type>(<scope>): <subject>\" -m \"<body>\" -m \"<footer>\"\n```\n\n### 4. Push to Remote\n\nAfter all commits are created:\n\n```bash\n# Review all commits before pushing\ngit log --oneline -n <number-of-commits>\n\n# Push to remote\ngit push origin <branch-name>\n```\n\n**Pre-push Checklist:**\n\n- ✅ All tests passing\n- ✅ Commits follow conventional format\n- ✅ Related changes grouped logically\n- ✅ Commit messages are clear and descriptive\n- ✅ No sensitive data in commits\n- ✅ Branch is up to date with remote (pull/rebase if needed)\n\n## Error Handling\n\nIf push fails:\n\n- **Conflict:** Pull latest changes, resolve conflicts, re-test, then push\n- **Rejected:** Check if branch protection requires PR or review\n- **Authentication:** Verify Git credentials and remote URL\n\n## Success Criteria\n\nThe workflow is complete when:\n\n1. All backend and frontend tests pass\n2. All changes are committed with proper messages\n3. Commits are successfully pushed to remote repository\n4. No errors or warnings in the process\n\n## Notes\n\n- Never skip tests even for \"small\" changes\n- Always verify production build succeeds for frontend changes\n- Keep commits atomic and focused\n- Write commit messages for future maintainers, not just yourself\n- Follow ToughRADIUS coding standards from `.github/copilot-instructions.md`", "variables": [], "notes": "Test, fix, commit, and push changes to the repository", "metadata": { "source": { "provider": "github-prompts", "repository": "https://github.com/talkincode/toughradius", "path": ".github/prompts/push.prompt.md", "ref": "d1d85a6aa4c2e91c48adcbc9cdfb977db712b40f", "url": "https://github.com/talkincode/toughradius/blob/d1d85a6aa4c2e91c48adcbc9cdfb977db712b40f/.github/prompts/push.prompt.md", "key": "talkincode/toughradius/.github/prompts/push.prompt.md" } } }

push

About

Test, Fix, Commit and Push Workflow

Workflow Steps

1. Run All Tests

2. Fix Issues

3. Commit Changes

4. Push to Remote

Error Handling

Success Criteria

Notes

Use it

Manifest

Reviews