Prompt file imported from JDKoll1982/MTM_Receiving_Application (.github/prompts/quality/mtm-module-code-review.prompt.md). Copyright stays with the author.

Module Code Review - Automated Analysis & Fix Application

Name: mtm-module-code-review
Author: JDKoll1982

Version: 1.0
Created: January 5, 2026
Agent: Code Review Sentinel

What This Does

Comprehensive code review and automated fix application for WinUI 3 modules in the MTM Receiving Application. The agent:

Analyzes entire module for critical vulnerabilities, architectural violations, and improvements
Generates CODE_REVIEW.md with categorized issues and checkboxes
Discovers hardcoded values for settings documentation
Applies fixes automatically after you amend the review
Validates build after EVERY fix
Tracks progress across sessions with persistent memory
Versions review documents when complete

Quick Start

Option 1: Copilot Slash Command (Recommended)

/review-module

The agent will ask which module to analyze or auto-detect from your current file.

Option 2: Direct Invocation

@code-reviewer analyze Module_Volvo

@code-reviewer I module-code-review

Workflow

Step 1: Analysis

Command: [I]init or [A]analyze

What happens:

Agent scans all Services, DAOs, ViewModels, Views, Models in target module
Applies 10+ severity categories (🔴 CRITICAL → 🟤 LOGGING/DOCS)
Detects hardcoded values for settings
Checks architectural violations against constitution
Generates CODE_REVIEW.md in module root
Creates {Module}Settings.md in Documentation/FutureEnhancements/Module_Settings/

Output:

✅ Analysis Complete for Module_Volvo

Generated:
- CODE_REVIEW.md (26 issues found)
- VolvoSettings.md (15 settings discovered)

Severity Breakdown:
🔴 CRITICAL: 3
🟡 SECURITY: 2
... (all severities)

Next: Review CODE_REVIEW.md and amend checkboxes

Step 2: Review & Amend

Open: {Module}/CODE_REVIEW.md

Amend checkboxes:

✅ = Apply this fix automatically
⬜ = Skip this fix (I'll handle manually or ignore)

Save the file with your amendments

Step 3: Apply Fixes

Command: [F]fix

What happens:

Agent reads your amended CODE_REVIEW.md
Groups fixes by dependencies (smart ordering)
Applies fixes one by one
Builds after EACH fix - stops on errors
Fixes build errors automatically when possible
Updates checkboxes as fixes complete
Tracks progress in memories

Flags:

--skip-maintain - Skip 🔧 MAINTAIN issues
--skip-logging - Skip 🟤 LOGGING/DOCS issues
--only-critical - Apply only 🔴 CRITICAL issues
--only-security - Apply only 🟡 SECURITY issues

Example:

@code-reviewer fix --only-critical

Output:

[1/26] Applying fix #2: Create stored procedure sp_volvo_shipment_update
✅ Build succeeded (3.2s)

[2/26] Applying fix #1: Update Dao to use stored proc
✅ Build succeeded (3.4s)

... (continues for all checked fixes)

🎉 Fix Application Complete!
Applied: 18/26 fixes
Build: ✅ Passing
Time: 54 minutes

Step 4: Generate Documentation

Command: [D]docs

What happens:

Analyzes all Services in module
Checks for existing .github/instructions/service-{name}.instructions.md
Compares service methods with documentation
Versions documentation if service changed (v1 → v2)
Generates new service instruction files
Updates {Module}Settings.md with hardcoded values

Output:

✅ Documentation Generation Complete

Service Documentation:
- Created: service-volvo.instructions.md
- Updated: service-volvo-masterdata.instructions.md (v1 → v2)

Settings Documentation:
- VolvoSettings.md updated (18 settings documented)

Step 5: Archive & Repeat

Command: [V]archive

When: All checkboxes are ✅ (review complete)

What happens:

Verifies all issues fixed
Creates Archived_Code_Reviews/ folder in module
Moves CODE_REVIEW.md → Archived_Code_Reviews/CODE_REVIEW_V1_20260105_143000.md
Updates memories with archived version
Asks: "Start new CODE_REVIEW_V2.md?"

Menu Commands

Command	Description
`[I]init`	Initialize or resume module review
`[A]analyze`	Analyze module and generate CODE_REVIEW.md
`[F]fix`	Apply fixes from amended CODE_REVIEW.md
`[D]docs`	Generate/update service documentation
`[S]status`	Show current review status and progress
`[V]archive`	Archive completed review and start new version
`[MH]menu/help`	Show this menu
`[CH]chat`	Chat with agent about review

Severity Categories

Icon	Name	Examples
🔴	CRITICAL	SQL injection, path traversal, data loss, no transactions
🟡	SECURITY	Missing authorization, input validation, hardcoded secrets
🟠	DATA	Race conditions, integrity violations, cascade delete issues
🔵	QUALITY	Magic strings, dead code, duplication, missing docs
🟣	PERFORMANCE	N+1 queries, inefficient collections, no caching
🔧	MAINTAIN	Complex validation, inconsistent naming, tech debt
🟢	EDGE CASE	Zero/negative values, null handling, boundary conditions
🎨	UI DESIGN	Workflow improvements, form usability, shortcuts
👤	UX	User feedback, error messages, progress indicators
🟤	LOGGING/DOCS	Missing logs, exception details, XML docs

What Gets Created

In Module Folder

Module_{Name}/
├── CODE_REVIEW.md                    # ← Main review document
├── CODE_REVIEW_V1_{timestamp}.md     # (moved to Archived_Code_Reviews/ when complete)
└── Archived_Code_Reviews/
    └── CODE_REVIEW_V1_20260105.md    # ← Archived versions

In Documentation Folder

Documentation/FutureEnhancements/Module_Settings/
└── {Module}Settings.md               # ← Configurable settings guide

In .github Folder

.github/instructions/
├── service-volvo.instructions.md          # ← Service guides
├── service-volvo-masterdata.instructions.md  # ← Updated guide with versioning

In Database Folder

Database/
├── StoredProcedures/{Module}/
│   └── sp_{operation}.sql            # ← New stored procedures
└── Migrations/
    └── {###}_{migration_name}.sql    # ← Schema migrations

Examples

Example 1: First-Time Module Analysis

User: @code-reviewer analyze Module_Volvo

Agent:
Found in Module_Volvo:
- 2 Services
- 4 DAOs
- 3 ViewModels
- 3 Views
- 4 Models

Analyzing...
✅ Analysis Complete
CODE_REVIEW.md generated with 26 issues

Next: Review and amend checkboxes

Example 2: Continuing Previous Review

User: @code-reviewer I

Agent:
Found existing CODE_REVIEW.md in Module_Volvo
Version: V1
Status: 8/26 fixes remaining

Last fix: Issue #17 - Large file check
Build: ✅ Passing

Ready to continue? [y/n]

Example 3: Applying Specific Fixes

User: @code-reviewer fix --only-critical

Agent:
Loading CODE_REVIEW.md...
Found 3 CRITICAL issues marked ✅

Execution Order:
Phase 1: Database
  - #2: Create stored procedure
  - #1: Update DAO to use stored proc
  
Phase 2: Validation
  - #3: Add path validation

Proceed? [y/n]

Configuration

File Access Boundaries

Agent can READ/WRITE:

Target Module_*/ directory
Database/StoredProcedures/{Module}/
Database/Migrations/
.github/instructions/service-*.instructions.md
.github/templates/code-review/
Documentation/FutureEnhancements/Module_Settings/

Agent CANNOT access:

Other modules (unless explicitly analyzing)
User data or external files
System files

Build & Test Settings

Build after each fix: ✅ Yes (mandatory)
Fix build errors: ✅ Automatic retry (up to 3 attempts)
Run tests: ❌ No (too time-consuming)
On build failure: Stop and repair before continuing

Memory Persistence

Agent remembers across sessions:

Current module and version
Fix progress (completed/remaining)
Module-specific patterns
Hardcoded values discovered
Last action taken

Located: _bmad/_memory/code-reviewer-sidecar/memories.md

Troubleshooting

"Build failed after fix"

Agent will:

Analyze error message
Attempt automatic fix (missing using, syntax, etc.)
Rebuild to confirm
Continue if fixed, or ask for help after 3 attempts

"Fix marked ✅ but not applied"

Possible causes:

Fix has dependencies (must fix #2 before #1)
File changed since analysis (re-analyze)
Build error prevented continuation

Solution: Run [S]status to see what's blocking

"Agent created wrong fix"

Steps:

Review git diff
Revert the specific file: git checkout -- {file}
Mark issue as ⬜ in CODE_REVIEW.md
Fix manually or ask agent to try different approach

"Module not found"

Solution: Ensure module folder exists and follows naming: Module_{Name}

List available modules:

Get-ChildItem -Directory -Filter "Module_*"

Advanced Usage

Custom Severity Analysis

Analyze only specific severity:

@code-reviewer analyze Module_Routing --only-critical

Resume After Interruption

@code-reviewer status
@code-reviewer fix

Agent remembers where it left off

Re-analyze Completed Module

@code-reviewer I
> Archive CODE_REVIEW_V1 and start new review? [y/n]

Useful after major refactoring

Batch Documentation Generation

@code-reviewer docs

Generates instruction files for ALL services in module

Best Practices

Review before fixing - Always amend CODE_REVIEW.md first
Start with CRITICAL - Use --only-critical for first pass
Test incrementally - Review changes every 5-10 fixes
Archive when done - Don't leave completed reviews unarchived
Keep settings docs - Implement settings page using generated docs
Version service docs - Agent auto-versions when service changes

Tips & Tricks

Quick status check: Type [S]status anytime to see progress
Chat mode: Use [CH]chat to ask questions about findings
Skip low-priority: Use --skip-maintain --skip-logging for fast pass
Fix order matters: Agent auto-detects dependencies
Build errors are OK: Agent will fix common build errors automatically
Memory persists: You can leave and come back - agent remembers

Related Documentation

Need Help?

@code-reviewer [MH]menu
@code-reviewer [CH]chat "How do I handle database-dependent fixes?"

Version: 1.0
Last Updated: January 5, 2026
Maintained By: Development Team

# Module Code Review - Automated Analysis & Fix Application **Version:** 1.0 **Created:** January 5, 2026 **Agent:** Code Review Sentinel --- ## What This Does Comprehensive code review and automated fix application for WinUI 3 modules in the MTM Receiving Application. The agent: 1. **Analyzes** entire module for critical vulnerabilities, architectural violations, and improvements 2. **Generates** CODE_REVIEW.md with categorized issues and checkboxes 3. **Discovers** hardcoded values for settings documentation 4. **Applies** fixes automatically after you amend the review 5. **Validates** build after EVERY fix 6. **Tracks** progress across sessions with persistent memory 7. **Versions** review documents when complete --- ## Quick Start ### Option 1: Copilot Slash Command (Recommended) ``` /review-module ``` The agent will ask which module to analyze or auto-detect from your current file. ### Option 2: Direct Invocation ``` @code-reviewer analyze Module_Volvo ``` or ``` @code-reviewer I module-code-review ``` --- ## Workflow ### Step 1: Analysis **Command:** `[I]init` or `[A]analyze` **What happens:** - Agent scans all Services, DAOs, ViewModels, Views, Models in target module - Applies 10+ severity categories (🔴 CRITICAL → 🟤 LOGGING/DOCS) - Detects hardcoded values for settings - Checks architectural violations against constitution - Generates `CODE_REVIEW.md` in module root - Creates `{Module}Settings.md` in Documentation/FutureEnhancements/Module_Settings/ **Output:** ``` ✅ Analysis Complete for Module_Volvo Generated: - CODE_REVIEW.md (26 issues found) - VolvoSettings.md (15 settings discovered) Severity Breakdown: 🔴 CRITICAL: 3 🟡 SECURITY: 2 ... (all severities) Next: Review CODE_REVIEW.md and amend checkboxes ``` ### Step 2: Review & Amend **Open:** `{Module}/CODE_REVIEW.md` **Amend checkboxes:** - `✅` = Apply this fix automatically - `⬜` = Skip this fix (I'll handle manually or ignore) **Save the file** with your amendments ### Step 3: Apply Fixes **Command:** `[F]fix` **What happens:** - Agent reads your amended CODE_REVIEW.md - Groups fixes by dependencies (smart ordering) - Applies fixes one by one - **Builds after EACH fix** - stops on errors - Fixes build errors automatically when possible - Updates checkboxes as fixes complete - Tracks progress in memories **Flags:** - `--skip-maintain` - Skip 🔧 MAINTAIN issues - `--skip-logging` - Skip 🟤 LOGGING/DOCS issues - `--only-critical` - Apply only 🔴 CRITICAL issues - `--only-security` - Apply only 🟡 SECURITY issues **Example:** ``` @code-reviewer fix --only-critical ``` **Output:** ``` [1/26] Applying fix #2: Create stored procedure sp_volvo_shipment_update ✅ Build succeeded (3.2s) [2/26] Applying fix #1: Update Dao to use stored proc ✅ Build succeeded (3.4s) ... (continues for all checked fixes) 🎉 Fix Application Complete! Applied: 18/26 fixes Build: ✅ Passing Time: 54 minutes ``` ### Step 4: Generate Documentation **Command:** `[D]docs` **What happens:** - Analyzes all Services in module - Checks for existing `.github/instructions/service-{name}.instructions.md` - Compares service methods with documentation - **Versions** documentation if service changed (v1 → v2) - Generates new service instruction files - Updates {Module}Settings.md with hardcoded values **Output:** ``` ✅ Documentation Generation Complete Service Documentation: - Created: service-volvo.instructions.md - Updated: service-volvo-masterdata.instructions.md (v1 → v2) Settings Documentation: - VolvoSettings.md updated (18 settings documented) ``` ### Step 5: Archive & Repeat **Command:** `[V]archive` **When:** All checkboxes are ✅ (review complete) **What happens:** - Verifies all issues fixed - Creates `Archived_Code_Reviews/` folder in module - Moves `CODE_REVIEW.md` → `Archived_Code_Reviews/CODE_REVIEW_V1_20260105_143000.md` - Updates memories with archived version - Asks: "Start new CODE_REVIEW_V2.md?" --- ## Menu Commands | Command | Description | |---------|-------------| | `[I]init` | Initialize or resume module review | | `[A]analyze` | Analyze module and generate CODE_REVIEW.md | | `[F]fix` | Apply fixes from amended CODE_REVIEW.md | | `[D]docs` | Generate/update service documentation | | `[S]status` | Show current review status and progress | | `[V]archive` | Archive completed review and start new version | | `[MH]menu/help` | Show this menu | | `[CH]chat` | Chat with agent about review | --- ## Severity Categories | Icon | Name | Examples | |------|------|----------| | 🔴 | CRITICAL | SQL injection, path traversal, data loss, no transactions | | 🟡 | SECURITY | Missing authorization, input validation, hardcoded secrets | | 🟠 | DATA | Race conditions, integrity violations, cascade delete issues | | 🔵 | QUALITY | Magic strings, dead code, duplication, missing docs | | 🟣 | PERFORMANCE | N+1 queries, inefficient collections, no caching | | 🔧 | MAINTAIN | Complex validation, inconsistent naming, tech debt | | 🟢 | EDGE CASE | Zero/negative values, null handling, boundary conditions | | 🎨 | UI DESIGN | Workflow improvements, form usability, shortcuts | | 👤 | UX | User feedback, error messages, progress indicators | | 🟤 | LOGGING/DOCS | Missing logs, exception details, XML docs | --- ## What Gets Created ### In Module Folder ``` Module_{Name}/ ├── CODE_REVIEW.md # ← Main review document ├── CODE_REVIEW_V1_{timestamp}.md # (moved to Archived_Code_Reviews/ when complete) └── Archived_Code_Reviews/ └── CODE_REVIEW_V1_20260105.md # ← Archived versions ``` ### In Documentation Folder ``` Documentation/FutureEnhancements/Module_Settings/ └── {Module}Settings.md # ← Configurable settings guide ``` ### In .github Folder ``` .github/instructions/ ├── service-volvo.instructions.md # ← Service guides ├── service-volvo-masterdata.instructions.md # ← Updated guide with versioning ``` ### In Database Folder ``` Database/ ├── StoredProcedures/{Module}/ │ └── sp_{operation}.sql # ← New stored procedures └── Migrations/ └── {###}_{migration_name}.sql # ← Schema migrations ``` --- ## Examples ### Example 1: First-Time Module Analysis ``` User: @code-reviewer analyze Module_Volvo Agent: Found in Module_Volvo: - 2 Services - 4 DAOs - 3 ViewModels - 3 Views - 4 Models Analyzing... ✅ Analysis Complete CODE_REVIEW.md generated with 26 issues Next: Review and amend checkboxes ``` ### Example 2: Continuing Previous Review ``` User: @code-reviewer I Agent: Found existing CODE_REVIEW.md in Module_Volvo Version: V1 Status: 8/26 fixes remaining Last fix: Issue #17 - Large file check Build: ✅ Passing Ready to continue? [y/n] ``` ### Example 3: Applying Specific Fixes ``` User: @code-reviewer fix --only-critical Agent: Loading CODE_REVIEW.md... Found 3 CRITICAL issues marked ✅ Execution Order: Phase 1: Database - #2: Create stored procedure - #1: Update DAO to use stored proc Phase 2: Validation - #3: Add path validation Proceed? [y/n] ``` --- ## Configuration ### File Access Boundaries Agent can **READ/WRITE**: - Target `Module_*/` directory - `Database/StoredProcedures/{Module}/` - `Database/Migrations/` - `.github/instructions/service-*.instructions.md` - `.github/templates/code-review/` - `Documentation/FutureEnhancements/Module_Settings/` Agent **CANNOT** access: - Other modules (unless explicitly analyzing) - User data or external files - System files ### Build & Test Settings - **Build after each fix:** ✅ Yes (mandatory) - **Fix build errors:** ✅ Automatic retry (up to 3 attempts) - **Run tests:** ❌ No (too time-consuming) - **On build failure:** Stop and repair before continuing ### Memory Persistence Agent remembers across sessions: - Current module and version - Fix progress (completed/remaining) - Module-specific patterns - Hardcoded values discovered - Last action taken Located: `_bmad/_memory/code-reviewer-sidecar/memories.md` --- ## Troubleshooting ### "Build failed after fix" **Agent will:** 1. Analyze error message 2. Attempt automatic fix (missing using, syntax, etc.) 3. Rebuild to confirm 4. Continue if fixed, or ask for help after 3 attempts ### "Fix marked ✅ but not applied" **Possible causes:** - Fix has dependencies (must fix #2 before #1) - File changed since analysis (re-analyze) - Build error prevented continuation **Solution:** Run `[S]status` to see what's blocking ### "Agent created wrong fix" **Steps:** 1. Review git diff 2. Revert the specific file: `git checkout -- {file}` 3. Mark issue as ⬜ in CODE_REVIEW.md 4. Fix manually or ask agent to try different approach ### "Module not found" **Solution:** Ensure module folder exists and follows naming: `Module_{Name}` List available modules: ```powershell Get-ChildItem -Directory -Filter "Module_*" ``` --- ## Advanced Usage ### Custom Severity Analysis Analyze only specific severity: ``` @code-reviewer analyze Module_Routing --only-critical ``` ### Resume After Interruption ``` @code-reviewer status @code-reviewer fix ``` Agent remembers where it left off ### Re-analyze Completed Module ``` @code-reviewer I > Archive CODE_REVIEW_V1 and start new review? [y/n] ``` Useful after major refactoring ### Batch Documentation Generation ``` @code-reviewer docs ``` Generates instruction files for ALL services in module --- ## Best Practices 1. **Review before fixing** - Always amend CODE_REVIEW.md first 2. **Start with CRITICAL** - Use `--only-critical` for first pass 3. **Test incrementally** - Review changes every 5-10 fixes 4. **Archive when done** - Don't leave completed reviews unarchived 5. **Keep settings docs** - Implement settings page using generated docs 6. **Version service docs** - Agent auto-versions when service changes --- ## Tips & Tricks - **Quick status check:** Type `[S]status` anytime to see progress - **Chat mode:** Use `[CH]chat` to ask questions about findings - **Skip low-priority:** Use `--skip-maintain --skip-logging` for fast pass - **Fix order matters:** Agent auto-detects dependencies - **Build errors are OK:** Agent will fix common build errors automatically - **Memory persists:** You can leave and come back - agent remembers --- ## Related Documentation - [Code Reviewer Agent](_bmad/agents/code-reviewer/code-reviewer.agent.yaml) - [MVVM Pattern Instructions](.github/instructions/architecture/mvvm-pattern.instructions.md) - [DAO Pattern Instructions](.github/instructions/architecture/dao-pattern.instructions.md) - [Constitution](.specify/memory/constitution.md) --- **Need Help?** ``` @code-reviewer [MH]menu @code-reviewer [CH]chat "How do I handle database-dependent fixes?" ``` --- **Version:** 1.0 **Last Updated:** January 5, 2026 **Maintained By:** Development Team

{ "prompt": "# Module Code Review - Automated Analysis & Fix Application\n\n**Version:** 1.0 \n**Created:** January 5, 2026 \n**Agent:** Code Review Sentinel\n\n---\n\n## What This Does\n\nComprehensive code review and automated fix application for WinUI 3 modules in the MTM Receiving Application. The agent:\n\n1. **Analyzes** entire module for critical vulnerabilities, architectural violations, and improvements\n2. **Generates** CODE_REVIEW.md with categorized issues and checkboxes\n3. **Discovers** hardcoded values for settings documentation\n4. **Applies** fixes automatically after you amend the review\n5. **Validates** build after EVERY fix\n6. **Tracks** progress across sessions with persistent memory\n7. **Versions** review documents when complete\n\n---\n\n## Quick Start\n\n### Option 1: Copilot Slash Command (Recommended)\n\n```\n/review-module\n```\n\nThe agent will ask which module to analyze or auto-detect from your current file.\n\n### Option 2: Direct Invocation\n\n```\n@code-reviewer analyze Module_Volvo\n```\n\nor\n\n```\n@code-reviewer I module-code-review\n```\n\n---\n\n## Workflow\n\n### Step 1: Analysis\n\n**Command:** `[I]init` or `[A]analyze`\n\n**What happens:**\n\n- Agent scans all Services, DAOs, ViewModels, Views, Models in target module\n- Applies 10+ severity categories (🔴 CRITICAL → 🟤 LOGGING/DOCS)\n- Detects hardcoded values for settings\n- Checks architectural violations against constitution\n- Generates `CODE_REVIEW.md` in module root\n- Creates `{Module}Settings.md` in Documentation/FutureEnhancements/Module_Settings/\n\n**Output:**\n\n```\n✅ Analysis Complete for Module_Volvo\n\nGenerated:\n- CODE_REVIEW.md (26 issues found)\n- VolvoSettings.md (15 settings discovered)\n\nSeverity Breakdown:\n🔴 CRITICAL: 3\n🟡 SECURITY: 2\n... (all severities)\n\nNext: Review CODE_REVIEW.md and amend checkboxes\n```\n\n### Step 2: Review & Amend\n\n**Open:** `{Module}/CODE_REVIEW.md`\n\n**Amend checkboxes:**\n\n- `✅` = Apply this fix automatically\n- `⬜` = Skip this fix (I'll handle manually or ignore)\n\n**Save the file** with your amendments\n\n### Step 3: Apply Fixes\n\n**Command:** `[F]fix`\n\n**What happens:**\n\n- Agent reads your amended CODE_REVIEW.md\n- Groups fixes by dependencies (smart ordering)\n- Applies fixes one by one\n- **Builds after EACH fix** - stops on errors\n- Fixes build errors automatically when possible\n- Updates checkboxes as fixes complete\n- Tracks progress in memories\n\n**Flags:**\n\n- `--skip-maintain` - Skip 🔧 MAINTAIN issues\n- `--skip-logging` - Skip 🟤 LOGGING/DOCS issues\n- `--only-critical` - Apply only 🔴 CRITICAL issues\n- `--only-security` - Apply only 🟡 SECURITY issues\n\n**Example:**\n\n```\n@code-reviewer fix --only-critical\n```\n\n**Output:**\n\n```\n[1/26] Applying fix #2: Create stored procedure sp_volvo_shipment_update\n✅ Build succeeded (3.2s)\n\n[2/26] Applying fix #1: Update Dao to use stored proc\n✅ Build succeeded (3.4s)\n\n... (continues for all checked fixes)\n\n🎉 Fix Application Complete!\nApplied: 18/26 fixes\nBuild: ✅ Passing\nTime: 54 minutes\n```\n\n### Step 4: Generate Documentation\n\n**Command:** `[D]docs`\n\n**What happens:**\n\n- Analyzes all Services in module\n- Checks for existing `.github/instructions/service-{name}.instructions.md`\n- Compares service methods with documentation\n- **Versions** documentation if service changed (v1 → v2)\n- Generates new service instruction files\n- Updates {Module}Settings.md with hardcoded values\n\n**Output:**\n\n```\n✅ Documentation Generation Complete\n\nService Documentation:\n- Created: service-volvo.instructions.md\n- Updated: service-volvo-masterdata.instructions.md (v1 → v2)\n\nSettings Documentation:\n- VolvoSettings.md updated (18 settings documented)\n```\n\n### Step 5: Archive & Repeat\n\n**Command:** `[V]archive`\n\n**When:** All checkboxes are ✅ (review complete)\n\n**What happens:**\n\n- Verifies all issues fixed\n- Creates `Archived_Code_Reviews/` folder in module\n- Moves `CODE_REVIEW.md` → `Archived_Code_Reviews/CODE_REVIEW_V1_20260105_143000.md`\n- Updates memories with archived version\n- Asks: \"Start new CODE_REVIEW_V2.md?\"\n\n---\n\n## Menu Commands\n\n| Command | Description |\n|---------|-------------|\n| `[I]init` | Initialize or resume module review |\n| `[A]analyze` | Analyze module and generate CODE_REVIEW.md |\n| `[F]fix` | Apply fixes from amended CODE_REVIEW.md |\n| `[D]docs` | Generate/update service documentation |\n| `[S]status` | Show current review status and progress |\n| `[V]archive` | Archive completed review and start new version |\n| `[MH]menu/help` | Show this menu |\n| `[CH]chat` | Chat with agent about review |\n\n---\n\n## Severity Categories\n\n| Icon | Name | Examples |\n|------|------|----------|\n| 🔴 | CRITICAL | SQL injection, path traversal, data loss, no transactions |\n| 🟡 | SECURITY | Missing authorization, input validation, hardcoded secrets |\n| 🟠 | DATA | Race conditions, integrity violations, cascade delete issues |\n| 🔵 | QUALITY | Magic strings, dead code, duplication, missing docs |\n| 🟣 | PERFORMANCE | N+1 queries, inefficient collections, no caching |\n| 🔧 | MAINTAIN | Complex validation, inconsistent naming, tech debt |\n| 🟢 | EDGE CASE | Zero/negative values, null handling, boundary conditions |\n| 🎨 | UI DESIGN | Workflow improvements, form usability, shortcuts |\n| 👤 | UX | User feedback, error messages, progress indicators |\n| 🟤 | LOGGING/DOCS | Missing logs, exception details, XML docs |\n\n---\n\n## What Gets Created\n\n### In Module Folder\n\n```\nModule_{Name}/\n├── CODE_REVIEW.md # ← Main review document\n├── CODE_REVIEW_V1_{timestamp}.md # (moved to Archived_Code_Reviews/ when complete)\n└── Archived_Code_Reviews/\n └── CODE_REVIEW_V1_20260105.md # ← Archived versions\n```\n\n### In Documentation Folder\n\n```\nDocumentation/FutureEnhancements/Module_Settings/\n└── {Module}Settings.md # ← Configurable settings guide\n```\n\n### In .github Folder\n\n```\n.github/instructions/\n├── service-volvo.instructions.md # ← Service guides\n├── service-volvo-masterdata.instructions.md # ← Updated guide with versioning\n```\n\n### In Database Folder\n\n```\nDatabase/\n├── StoredProcedures/{Module}/\n│ └── sp_{operation}.sql # ← New stored procedures\n└── Migrations/\n └── {###}_{migration_name}.sql # ← Schema migrations\n```\n\n---\n\n## Examples\n\n### Example 1: First-Time Module Analysis\n\n```\nUser: @code-reviewer analyze Module_Volvo\n\nAgent:\nFound in Module_Volvo:\n- 2 Services\n- 4 DAOs\n- 3 ViewModels\n- 3 Views\n- 4 Models\n\nAnalyzing...\n✅ Analysis Complete\nCODE_REVIEW.md generated with 26 issues\n\nNext: Review and amend checkboxes\n```\n\n### Example 2: Continuing Previous Review\n\n```\nUser: @code-reviewer I\n\nAgent:\nFound existing CODE_REVIEW.md in Module_Volvo\nVersion: V1\nStatus: 8/26 fixes remaining\n\nLast fix: Issue #17 - Large file check\nBuild: ✅ Passing\n\nReady to continue? [y/n]\n```\n\n### Example 3: Applying Specific Fixes\n\n```\nUser: @code-reviewer fix --only-critical\n\nAgent:\nLoading CODE_REVIEW.md...\nFound 3 CRITICAL issues marked ✅\n\nExecution Order:\nPhase 1: Database\n - #2: Create stored procedure\n - #1: Update DAO to use stored proc\n \nPhase 2: Validation\n - #3: Add path validation\n\nProceed? [y/n]\n```\n\n---\n\n## Configuration\n\n### File Access Boundaries\n\nAgent can **READ/WRITE**:\n\n- Target `Module_*/` directory\n- `Database/StoredProcedures/{Module}/`\n- `Database/Migrations/`\n- `.github/instructions/service-*.instructions.md`\n- `.github/templates/code-review/`\n- `Documentation/FutureEnhancements/Module_Settings/`\n\nAgent **CANNOT** access:\n\n- Other modules (unless explicitly analyzing)\n- User data or external files\n- System files\n\n### Build & Test Settings\n\n- **Build after each fix:** ✅ Yes (mandatory)\n- **Fix build errors:** ✅ Automatic retry (up to 3 attempts)\n- **Run tests:** ❌ No (too time-consuming)\n- **On build failure:** Stop and repair before continuing\n\n### Memory Persistence\n\nAgent remembers across sessions:\n\n- Current module and version\n- Fix progress (completed/remaining)\n- Module-specific patterns\n- Hardcoded values discovered\n- Last action taken\n\nLocated: `_bmad/_memory/code-reviewer-sidecar/memories.md`\n\n---\n\n## Troubleshooting\n\n### \"Build failed after fix\"\n\n**Agent will:**\n\n1. Analyze error message\n2. Attempt automatic fix (missing using, syntax, etc.)\n3. Rebuild to confirm\n4. Continue if fixed, or ask for help after 3 attempts\n\n### \"Fix marked ✅ but not applied\"\n\n**Possible causes:**\n\n- Fix has dependencies (must fix #2 before #1)\n- File changed since analysis (re-analyze)\n- Build error prevented continuation\n\n**Solution:**\nRun `[S]status` to see what's blocking\n\n### \"Agent created wrong fix\"\n\n**Steps:**\n\n1. Review git diff\n2. Revert the specific file: `git checkout -- {file}`\n3. Mark issue as ⬜ in CODE_REVIEW.md\n4. Fix manually or ask agent to try different approach\n\n### \"Module not found\"\n\n**Solution:**\nEnsure module folder exists and follows naming: `Module_{Name}`\n\nList available modules:\n\n```powershell\nGet-ChildItem -Directory -Filter \"Module_*\"\n```\n\n---\n\n## Advanced Usage\n\n### Custom Severity Analysis\n\nAnalyze only specific severity:\n\n```\n@code-reviewer analyze Module_Routing --only-critical\n```\n\n### Resume After Interruption\n\n```\n@code-reviewer status\n@code-reviewer fix\n```\n\nAgent remembers where it left off\n\n### Re-analyze Completed Module\n\n```\n@code-reviewer I\n> Archive CODE_REVIEW_V1 and start new review? [y/n]\n```\n\nUseful after major refactoring\n\n### Batch Documentation Generation\n\n```\n@code-reviewer docs\n```\n\nGenerates instruction files for ALL services in module\n\n---\n\n## Best Practices\n\n1. **Review before fixing** - Always amend CODE_REVIEW.md first\n2. **Start with CRITICAL** - Use `--only-critical` for first pass\n3. **Test incrementally** - Review changes every 5-10 fixes\n4. **Archive when done** - Don't leave completed reviews unarchived\n5. **Keep settings docs** - Implement settings page using generated docs\n6. **Version service docs** - Agent auto-versions when service changes\n\n---\n\n## Tips & Tricks\n\n- **Quick status check:** Type `[S]status` anytime to see progress\n- **Chat mode:** Use `[CH]chat` to ask questions about findings\n- **Skip low-priority:** Use `--skip-maintain --skip-logging` for fast pass\n- **Fix order matters:** Agent auto-detects dependencies\n- **Build errors are OK:** Agent will fix common build errors automatically\n- **Memory persists:** You can leave and come back - agent remembers\n\n---\n\n## Related Documentation\n\n- [Code Reviewer Agent](_bmad/agents/code-reviewer/code-reviewer.agent.yaml)\n- [MVVM Pattern Instructions](.github/instructions/architecture/mvvm-pattern.instructions.md)\n- [DAO Pattern Instructions](.github/instructions/architecture/dao-pattern.instructions.md)\n- [Constitution](.specify/memory/constitution.md)\n\n---\n\n**Need Help?**\n\n```\n@code-reviewer [MH]menu\n@code-reviewer [CH]chat \"How do I handle database-dependent fixes?\"\n```\n\n---\n\n**Version:** 1.0 \n**Last Updated:** January 5, 2026 \n**Maintained By:** Development Team", "variables": [], "notes": "Comprehensive code review and automated fix application for WinUI 3 modules in the MTM Receiving Application. The agent:", "metadata": { "source": { "provider": "github-prompts", "repository": "https://github.com/JDKoll1982/MTM_Receiving_Application", "path": ".github/prompts/quality/mtm-module-code-review.prompt.md", "ref": "e166978f422dc33d82a6792c754b7f4fcf53888d", "url": "https://github.com/JDKoll1982/MTM_Receiving_Application/blob/e166978f422dc33d82a6792c754b7f4fcf53888d/.github/prompts/quality/mtm-module-code-review.prompt.md", "key": "JDKoll1982/MTM_Receiving_Application/.github/prompts/quality/mtm-module-code-review.prompt.md" } } }

About

Module Code Review - Automated Analysis & Fix Application

What This Does

Quick Start

Option 1: Copilot Slash Command (Recommended)

Option 2: Direct Invocation

Workflow

Step 1: Analysis

Step 2: Review & Amend

Step 3: Apply Fixes

Step 4: Generate Documentation

Step 5: Archive & Repeat

Menu Commands

Severity Categories

What Gets Created

In Module Folder

In Documentation Folder

In .github Folder

In Database Folder

Examples

Example 1: First-Time Module Analysis

Example 2: Continuing Previous Review

Example 3: Applying Specific Fixes

Configuration

File Access Boundaries

Build & Test Settings

Memory Persistence

Troubleshooting

"Build failed after fix"

"Fix marked ✅ but not applied"

"Agent created wrong fix"

"Module not found"

Advanced Usage

Custom Severity Analysis

Resume After Interruption

Re-analyze Completed Module

Batch Documentation Generation

Best Practices

Tips & Tricks

Related Documentation

Use it

Manifest

Reviews