Instruction file imported from brndnmtthws/conky (.github/instructions/cmake-review.instructions.md). Copyright stays with the author.

Conky Build-System Review Instructions

Name: cmake-review
Author: brndnmtthws

Prioritize build reproducibility and CI parity.

Focus review comments on:

Option defaults and interactions (MAINTAINER_MODE, BUILD_TESTING, CHECK_CODE_QUALITY, CODE_COVERAGE) that may change expected developer or CI behavior.
Platform/compiler conditionals that could break Linux/macOS matrix builds.
Dependency/linking changes that risk optional feature regressions.
New targets/commands that are not wired into existing workflows or documented usage.

Validation expectations:

Build paths should remain compatible with cmake . -B build -G Ninja -DMAINTAINER_MODE=ON.
Test execution should remain compatible with ctest --output-on-failure from build/.
Format-related guidance should align with available targets (clang-format, check-clang-format) and their configuration preconditions.

Raise comments when CMake changes alter cache variable semantics without migration notes or clear rationale.

{ "ocm": "1", "id": "brndnmtthws-conky-cmake-review-instructions", "kind": "skill", "name": "cmake-review", "description": "Prioritize build reproducibility and CI parity.", "publisher": "brndnmtthws", "version": "1.0.0", "capabilities": { "domains": [ "general" ], "tags": [ "skill-md", "github-instructions" ], "languages": [ "en" ] }, "quality_prior": 0.6, "examples": [ "Prioritize build reproducibility and CI parity." ], "primary": false, "metadata": { "source": { "provider": "github-instructions", "repository": "https://github.com/brndnmtthws/conky", "path": ".github/instructions/cmake-review.instructions.md", "ref": "ef154d5a2f981142865c37efa6a1a25485762c5a", "url": "https://github.com/brndnmtthws/conky/blob/ef154d5a2f981142865c37efa6a1a25485762c5a/.github/instructions/cmake-review.instructions.md", "key": "brndnmtthws/conky/.github/instructions/cmake-review.instructions.md" }, "applies_to": "CMakeLists.txt,cmake/**/*.cmake,tests/CMakeLists.txt,src/CMakeLists.txt,lua/CMakeLists.txt,data/CMakeLists.txt,doc/CMakeLists.txt,extras/CMakeLists.txt,3rdparty/CMakeLists.txt" }, "instructions": "# Conky Build-System Review Instructions\n\nPrioritize build reproducibility and CI parity.\n\nFocus review comments on:\n\n- Option defaults and interactions (`MAINTAINER_MODE`, `BUILD_TESTING`, `CHECK_CODE_QUALITY`, `CODE_COVERAGE`) that may change expected developer or CI behavior.\n- Platform/compiler conditionals that could break Linux/macOS matrix builds.\n- Dependency/linking changes that risk optional feature regressions.\n- New targets/commands that are not wired into existing workflows or documented usage.\n\nValidation expectations:\n\n- Build paths should remain compatible with `cmake . -B buil", "cost": { "context_tokens": 243 } }

cmake-review

About

Conky Build-System Review Instructions

Use it

Manifest

Reviews